Get-PackageParameters - Resolve differences between chocolatey.core-extension and built-in method #1490
Comments
ferventcoder
changed the title
|
The removal is intentional as the resulting path always works unlike quoted path. |
|
@majkinetor I'm guessing. When I originally diverged, the thought was that someone could pass with partial quotes. But that would also work, so long as it is not surrounding the entire parameter value. 👍 |
ferventcoder
added a commit
to ferventcoder/choco
that referenced
this issue
Feb 20, 2018
It was noted that there is a discrepancy with how the built-in `Get-PackageParameters` behaves differently and in an incompatible way as compared to the the core extension's old version of `Get-PackageParameters`. The built-in Get-PackageParameters should do at least what core extension does and then enhance on that with more. To remove the noted incompatibility, it should handle quotes and apostrophes surrounding the items in the same way, which is to remove them as it loads the parameter values into the hash table.
ferventcoder
added a commit
that referenced
this issue
Feb 20, 2018
It was noted that there is a discrepancy with how the built-in `Get-PackageParameters` behaves differently and in an incompatible way as compared to the the core extension's old version of `Get-PackageParameters`. The built-in Get-PackageParameters should do at least what core extension does and then enhance on that with more. To remove the noted incompatibility, it should handle quotes and apostrophes surrounding the items in the same way, which is to remove them as it loads the parameter values into the hash table.
ferventcoder
added a commit
that referenced
this issue
Feb 20, 2018
* stable: (35 commits) (GH-1478) Upgrade 7z to 18.1 (GH-1490) Remove quotes/apostrophes surrounding parameter (maint) virtualize get_package_information (maint) virtualize all calls in NuGetService (GH-100) Log without colorization (GH-100) add no color feature/option (GH-100) add no color log4net config files (maint) formatting (#1489) Log PowerShell contents w/out formatting (maint) Some options could be achieved w/FOSS (maint) Add instructions for strong naming NuGet (maint) update licensing code (GH-1488) License validation logging (specs) add pack scenario nuspec (maint) Whitespace changes (GH-1500) Disable re-validation of Chocolatey License File (doc) update etiquette statement (build) allow builds with any .NET 4.x (doc) update licensed changelog (maint) update licensing ... # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In chocolatey-community/chocolatey-packages#950 it was noted that the built-in
Get-PackageParametershas some incompatibilities with the original chocolatey.core-extension'sGet-PackageParameters. We've already made enhancements with #1459 (due out with v0.10.9), but we needed more to work in the same way thatGet-PackageParameters(core extension) does.To expand on this, the built-in
Get-PackageParametersshould do at least what core extension does and then enhance on that with more.One of the discrepancies was how it handles quotes and apostrophes as it loads items into the hash table. The original removes the quotes/apostrophes surrounding the items, so the built-in should mimic that behavior. If folks want to put them back, that is fine.
The text was updated successfully, but these errors were encountered: