Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging - Choco --log-file option should create log files relative to current directory #1603

Closed
pauby opened this issue Jun 26, 2018 · 2 comments
Closed

Logging - Choco --log-file option should create log files relative to current directory #1603

pauby opened this issue Jun 26, 2018 · 2 comments
Assignees
@gep13
Labels
5 - Released Customer Improvement
Milestone
0.10.12

Comments

@pauby
Copy link
Member

pauby commented Jun 26, 2018 •
edited by gep13
Loading

This was checked using FOSS and all licensed versions of v0.10.11 with the same results.

What You Are Seeing?

When using the --log-file parameter I see the following:

  • If you specify a relative filename (ie. --log-file=test.log) the file is created under the Chocolatey ProgramData folder rather than in the current folder;
  • If you specify a relative path (ie. --log-file=temp\test.log) an empty folder temp is created under the current folder and the full path (temp\test.log) is created under the Chocolatey ProgramData folder;
  • If you specify a full path (ie. --log-file=c:\temp\test.log) the log file is created correctly at c:\temp\test.log;

What is Expected?

I'd expect relative paths to be create under the current folder and not under Chocolatey ProgramData.

How Did You Get This To Happen? (Steps to Reproduce)

choco new test <LOG FILE PARAMS FROM ABOVE>
@ferventcoder ferventcoder added this to the 0.10.12 milestone Sep 26, 2018
@ferventcoder
Copy link
Member

Added to the backlog!

@ferventcoder ferventcoder changed the title Choco --log-file parameter does not create log files relative to current directory Logging - Choco --log-file parameter does not create log files relative to current directory Sep 26, 2018
gep13 added a commit to gep13/choco that referenced this issue Mar 13, 2019
@gep13
(chocolateyGH-1603) Ensure full path to log is used
22f2dc8 
Use helper method in IFileSystem implementation to ensure that the full
path to the requested log file is used, rather than making it relative
to where Chocolatey is currently located.
@gep13 gep13 mentioned this issue Mar 13, 2019
Closed
gep13 added a commit to gep13/choco that referenced this issue Mar 13, 2019
@gep13
(chocolateyGH-1603) Ensure full path to log is used
a104083 
Use helper method in IFileSystem implementation to ensure that the full
path to the requested log file is used, rather than making it relative
to where Chocolatey is currently located.
ferventcoder pushed a commit that referenced this issue Mar 13, 2019
@gep13 @ferventcoder
(GH-1603) Ensure full path for log when relative path provided
7917dc6 
Use helper method in IFileSystem implementation to ensure that the full
path to the requested log file is used, rather than making it relative
to where Chocolatey is currently located.
ferventcoder added a commit that referenced this issue Mar 13, 2019
@ferventcoder
Merge branch 'pr1752' into stable
3cd9c0d 
* pr1752:
  (GH-1603) Ensure full path for log when relative path provided
ferventcoder added a commit that referenced this issue Mar 13, 2019
@ferventcoder
Merge branch 'stable'
23a28b7 
* stable:
  (GH-1603) Ensure full path for log when relative path provided
@ferventcoder
Copy link
Member

This will be released with 0.10.12.

@ferventcoder ferventcoder changed the title Logging - Choco --log-file parameter does not create log files relative to current directory Logging - Choco --log-file option should create log files relative to current directory Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @pauby