Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Semantic Versioning 2.0.0 (semver) #1610

Closed
watashiSHUN opened this issue Jul 6, 2018 · 17 comments
Closed

Support Semantic Versioning 2.0.0 (semver) #1610

watashiSHUN opened this issue Jul 6, 2018 · 17 comments

Comments

@watashiSHUN
Copy link

what version of nuget is chocolatey using? looking at NuGet.exe under .nuget/, I am getting 1.7.0 which is pretty ancient. Anyway, right now I can not pack with version number following SemVer2.0.0:
image

but this is supported in nuget4.3.0+:
image

@watashiSHUN
Copy link
Author

@#1528

@bcurran3
Copy link

Since this hasn't been officially answered. I'll unofficially answer it.

Deducing from "https://chocolatey.org/api/v2/" I'd say Chocolatey is still using nuget v2.

@ferventcoder has some comments somewhere (paraphrasing) saying that nuget v3 is not in a finished state yet. (Don't know if it still holds true as of today.)

@ferventcoder ferventcoder changed the title support Semantic Versioning 2.0.0 Support Semantic Versioning 2.0.0 (semver) Sep 26, 2018
@ferventcoder
Copy link
Member

@watashiSHUN Chocolatey != NuGet. Chocolatey uses NuGet and enhances, but the two are not quite equal in terms of what they support. We are working on supporting SemVer v2 though, and we hoped to have it ready in 0.10.11. @bcurran3 is correct that Chocolatey has enhancements on top of NuGet v2 - we have it on the roadmap to move to NuGet vNewer, but it's not the easiest upgrade to support as it is not a 1:1, so we want to have all of the different things for testing infra in place prior to the upgrade to catch any unexpected issues.

@ferventcoder ferventcoder added this to the 0.10.12 milestone Sep 26, 2018
@ferventcoder
Copy link
Member

Added this to the backlog, I thought we actually had an issue in here somewhere but I was unable to locate it. Thanks for writing that up!

@Thilas
Copy link

Thilas commented Jan 15, 2019

@ferventcoder, do you have an idea when this might come? Would a PR help? I'm interested in it for 2 reasons:

  1. I have some packages that would benefit from it
  2. I need to patch AU to make it SemVer 2 aware as soon as choco is

Thanks

@ferventcoder ferventcoder self-assigned this Jan 18, 2019
@ferventcoder
Copy link
Member

@Thilas while this would get into Chocolatey itself in vNext, it will also need to be added to Chocolatey.org to work up there. I wonder if we have an issue on it up there yet?

@Thilas
Copy link

Thilas commented Jan 22, 2019

@ferventcoder, what do you mean? That we can already test it on choco itself? Is there anything I can do to help?

@kijanawoodard
Copy link

Does getting to semver 2.0.0 require upgrading nuget?
if so, is there a clear list of issues to get there?

@JRSerjeant
Copy link

Is there any timeline for the this will be included?

@ferventcoder
Copy link
Member

We have a hoped timeline, but it needs to make the cut for releasing bits. Then we'll need to make changes to support it on Chocolatey.org as well.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
Previously, when running some of the pack scenarios in Visual Studio,
some of the resulting packages contained the entire contents of the debug
folder, which slowed the the test as it took longer to pack.
This add a dependency and empty files element, so only the nuspec is packed.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
…ing zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
…ing zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
…ing zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
… with leading zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
…stall with leading zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
… zeros

These tests are to ensure that the version normalization on pack with the
new NuGet assemblies is consistent into the future. There were already tests
for removing semver v2 build metadata and that four part versions still work.
This adds tests to ensure that leading zeros are removed, and that a zero in
the fourth part of the version will be trimmed down to three parts.
https://learn.microsoft.com/en-us/nuget/concepts/package-versioning#normalized-version-numbers
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
Previously, when running some of the pack scenarios in Visual Studio,
some of the resulting packages contained the entire contents of the debug
folder, which slowed the the test as it took longer to pack.
This add a dependency and empty files element, so only the nuspec is packed.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
…s with leading zeros

Also adds install tests for packages with a forth part zero
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Jan 16, 2023
… zeros

These tests are to ensure that the version normalization on pack with the
new NuGet assemblies is consistent into the future. There were already tests
for removing semver v2 build metadata and that four part versions still work.
This adds tests to ensure that leading zeros are removed, and that a zero in
the fourth part of the version will be trimmed down to three parts.
https://learn.microsoft.com/en-us/nuget/concepts/package-versioning#normalized-version-numbers
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Jan 16, 2023
Previously, when running some of the pack scenarios in Visual Studio,
some of the resulting packages contained the entire contents of the debug
folder, which slowed the the test as it took longer to pack.
This add a dependency and empty files element, so only the nuspec is packed.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Jan 16, 2023
…s with leading zeros

Also adds install tests for packages with a forth part zero
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Jan 16, 2023
gep13 added a commit that referenced this issue Jan 16, 2023
(#1174)(#1610) Add tests for package versions with leading zeros
@gep13
Copy link
Member

gep13 commented Jan 24, 2023

Due to the uplift to the latest NuGet Client assemblies, this is now supported within Chocolatey CLI.

@gep13 gep13 closed this as completed Jan 24, 2023
@gep13 gep13 removed the Requires NuGet.Client Change This issue requires a modification to something in referenced NuGet.Client library. label Mar 21, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests