Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade - switch for not installing if not installed #1646

Closed
ferventcoder opened this issue Sep 25, 2018 · 3 comments
Closed

upgrade - switch for not installing if not installed #1646

ferventcoder opened this issue Sep 25, 2018 · 3 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement
Milestone
0.10.12

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Sep 25, 2018 •
edited
Loading

If something is not installed, there should be an option to ignore installations for upgrades.
Something like --skip-if-not-installed or --only-upgrade-installed (or something like that).

#Release Notes
Provide a feature switch skipPackageUpgradesWhenNotInstalled that can
be overridden in the upgrade command with either
--skip-if-not-installed or --install-if-not-installed (the
later only being necessary when the feature switch has been flipped on).
@ferventcoder ferventcoder added this to the 0.10.12 milestone Sep 25, 2018
@ferventcoder ferventcoder self-assigned this Sep 25, 2018
@ferventcoder ferventcoder changed the title upgrade - switch for not upgrading if not installed upgrade - switch for not installing if not installed Sep 28, 2018
@tjfryan
Copy link

tjfryan commented Nov 14, 2018 •
edited
Loading

How similar is this to the feature added in #300
Edit: 7baa127#diff-7febe3f7caaaa2c63860a3a977c64fd7

@ferventcoder
Copy link
Member Author

The commit you linked, similar to that, but doesn't error.

@ferventcoder
Copy link
Member Author

So successful exit code instead of a failing exit code.

ferventcoder added a commit that referenced this issue Mar 5, 2019
@ferventcoder
(GH-1646) upgrade - skip non-installed packages
6b446a5 
Previously, if a package was not installed, during upgrade it would
install the package to meet the end state of having a package installed
and up to the latest version. However in some cases, it may be desired
to have the installation skip those packages and continue on, passing a
successful exit code instead of a failure like it would with
`--fail-on-not-installed` (which has similar behavior).

Provide a feature switch `skipPackageUpgradesWhenNotInstalled` that can
be overridden in the upgrade command with either
`--skip-if-not-installed` or `--install-if-not-installed` (the
later only being necessary when the feature switch has been flipped on).
ferventcoder added a commit that referenced this issue Mar 5, 2019
@ferventcoder
Merge branch 'stable'
7759dfe 
* stable:
  (#612) Do not fail on failing repos
  (GH-1646) upgrade - skip non-installed packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @tjfryan