Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Allow verifying DI Container in release build #1738

Closed
ferventcoder opened this issue Feb 24, 2019 · 0 comments
Closed

[API] Allow verifying DI Container in release build #1738

ferventcoder opened this issue Feb 24, 2019 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released API Improvement
Milestone
0.10.12

Comments

@ferventcoder
Copy link
Member

Currently the container is only verified if it is a debug build, but for API usage it might be helpful to allow to switch the setting.
@ferventcoder ferventcoder added this to the 0.10.12 milestone Feb 24, 2019
@ferventcoder ferventcoder self-assigned this Feb 24, 2019
ferventcoder added a commit that referenced this issue Feb 24, 2019
@ferventcoder
(GH-1738)(api) Change DI container verification
e4444ad 
Previously, verifying the DI container only happened in DEBUG builds.
This didn't leave a path to run the verification in RELEASE builds with
the API. Allow for that to be done.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 24, 2019
@ferventcoder
Merge branch 'stable'
047cd50 
* stable:
  (chocolateyGH-1738)(api) Change DI container verification
  (maint) add logging for Lets
  (maint) formatting
  (chocolateyGH-1735) Globally resolve assemblies w/out locking
  (maint) remove unused file
  (doc) update copyright year
  (doc) add VERIFICATION
  (maint) update copyright year
  (chocolateyGH-1734) Fix: Exit 1 if package throws an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released API Improvement
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
2 participants
@ferventcoder @gep13