Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolatey remembers --forceX86 value with subsequent packages #1772

Closed
flcdrg opened this issue Mar 21, 2019 · 3 comments
Closed

Chocolatey remembers --forceX86 value with subsequent packages #1772

flcdrg opened this issue Mar 21, 2019 · 3 comments
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.10.14

Comments

@flcdrg
Copy link
Member

flcdrg commented Mar 21, 2019

What You Are Seeing?

Boxstarter calling Chocolatey where the first package specifies --x86 then causes all subsequent packages to be installed as though --x86 was specified

What is Expected?

Only install x86 packages when explicitly requested

How Did You Get This To Happen? (Steps to Reproduce)

This relates to chocolatey/boxstarter#240

Looking at prepare_powershell_environment, there's a bunch of environment variables that are nulled out at the start, but not chocolateyForceX86.

I'm thinking this should be nulled out as well
flcdrg added a commit to flcdrg/choco that referenced this issue Mar 21, 2019
@flcdrg
Ensure chocolateyForceX86 is only set when requested
53608da 
- Fixes chocolatey#1772
@flcdrg flcdrg mentioned this issue Mar 21, 2019
Closed
@ferventcoder ferventcoder added this to the 0.10.14 milestone Mar 22, 2019
@ferventcoder ferventcoder self-assigned this Mar 22, 2019
@ferventcoder
Copy link
Member

This is fixed for 0.10.14. There is a beta that will be available soon for testing.

@ferventcoder
Copy link
Member

Hi @flcdrg - totally missed your PR. 😢

@ferventcoder
Copy link
Member

This is pushed up as a beta. This one is for chocolatey.lib.

ferventcoder added a commit that referenced this issue Apr 1, 2019
@ferventcoder
(GH-1772) Fix: choco remembers Forcex86
3e89841 
Ensure that Force X86 is reset each time a package is called.
ferventcoder added a commit that referenced this issue Apr 1, 2019
@ferventcoder
(GH-1772) Null out env var for Download Cache
e8bd27e 
Ensure that Download Cache Available environment variable is also
nulled out.
ferventcoder added a commit that referenced this issue Apr 1, 2019
@ferventcoder
Merge branch 'stable'
04f920d 
* stable:
  (GH-1784) Turn off enhanced exit codes by default
  (version) 0.10.14-beta
  (GH-1772) Null out env var for Download Cache
  (GH-1772) Fix: choco remembers Forcex86
  (maint) formatting / order
@ferventcoder ferventcoder changed the title Chocolatey remembers --forceX86 value Chocolatey remembers --forceX86 value with subsequent packages May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.10.14
Development

No branches or pull requests
3 participants
@ferventcoder @flcdrg @gep13