Allow -source of choco push to use source names as Input
#2219
Labels
Comments
|
Isn't this a duplicate of #63? |
|
@TheCakeIsNaOH This is indeed a duplicate of #63. Thanks for reaching out i'll close this issue. |
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Apr 14, 2023
Having this logic in the ParseAdditionalArguments method makes the command useless if there isn't a --source or defaultPushSource set. The error that would occur happens before the command can even output help information, and this also interferes with licensed functionality. This change moves the checks into the Validate method and consolidates the validation slightly as there was some double-work being done with the validation logic being somewhat split between the two methods.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Apr 14, 2023
The tests were written to expect the throwing from the argument parsing rather than the Validate method where they now throw. Moved these tests into the proper place and amended them where necessary.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Apr 14, 2023
The tests were written to expect the throwing from the argument parsing rather than the Validate method where they now throw. Moved these tests into the proper place and amended them where necessary.
10 tasks
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Apr 14, 2023
Having this logic in the ParseAdditionalArguments method makes the command useless if there isn't a --source or defaultPushSource set. The error that would occur happens before the command can even output help information, and this also interferes with licensed functionality. This change moves the checks into the Validate method and consolidates the validation slightly as there was some double-work being done with the validation logic being somewhat split between the two methods.
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Apr 14, 2023
The tests were written to expect the throwing from the argument parsing rather than the Validate method where they now throw. Moved these tests into the proper place and amended them where necessary.
corbob
added a commit
that referenced
this issue
Apr 14, 2023
(#2219) Defer errors from defaultpushsource until validation for ChocolateyPushCommand
|
Duplicate of #63 |
|
The commits that are tagged against this issue will ultimately be related to the duplicate issue linked above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Allow the
-sourceswitch of thechoco pushcommand to accept source names as input. Currently the source switch only accepts URLs as input.The text was updated successfully, but these errors were encountered: