Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong item set for overriding credentials when using remembered arguments during upgrade #2752

Closed
TheCakeIsNaOH opened this issue Jun 30, 2022 · 1 comment · Fixed by #2753
Assignees
Labels
5 - Released Bug IN MANUAL TEST SUITE These are things that are documented to test as part of a release.
Milestone

Comments

@TheCakeIsNaOH
Copy link
Member

What You Are Seeing?

During upgrading and using remembered argument, while overriding the password, certificate, and certificate password respectively, instead the username is being set to the wrong thing three times.

if (!string.IsNullOrWhiteSpace(originalConfig.SourceCommand.Password)) config.SourceCommand.Username = originalConfig.SourceCommand.Password;
if (!string.IsNullOrWhiteSpace(originalConfig.SourceCommand.Certificate)) config.SourceCommand.Username = originalConfig.SourceCommand.Certificate;
if (!string.IsNullOrWhiteSpace(originalConfig.SourceCommand.CertificatePassword)) config.SourceCommand.Username = originalConfig.SourceCommand.CertificatePassword;

What is Expected?

That the password, certificate, and certificate password are set, instead of the username.

How Did You Get This To Happen? (Steps to Reproduce)

N/A

System Details

N/A

Output Log

N/A

Full Log Output

IF YOUR LOG CONTENT IS SHORT, PLACE IT HERE - WE NEED _ALL_ DETAILED OUTPUT BASED ON THE ABOVE TO BE ABLE TO PROVIDE SUPPORT (YOU WILL FIND THAT IN THE $env:ChocolateyInstall\logs\chocolatey.log between the `=====`)
IF YOUR LOG CONTENT IS LONG, PLEASE LINK TO A GIST (see https://docs.github.com/en/github/writing-on-github/editing-and-sharing-content-with-gists/creating-gists)

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 30, 2022
Sets the correct config item instead of setting the Username with
three incorrect values.
@TheCakeIsNaOH TheCakeIsNaOH self-assigned this Jun 30, 2022
@gep13 gep13 added this to the 1.2.0 milestone Jun 30, 2022
gep13 added a commit that referenced this issue Jun 30, 2022
(#2752) Set correct items when overriding remembered arguments
@gep13 gep13 added 4 - Done and removed 3 - Review labels Jun 30, 2022
@pauby pauby added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Aug 24, 2022
@AdmiringWorm AdmiringWorm added IN MANUAL TEST SUITE These are things that are documented to test as part of a release. and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Sep 23, 2022
@AdmiringWorm
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released Bug IN MANUAL TEST SUITE These are things that are documented to test as part of a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants