Do not run autouninstaller if the package result is already a failure #323
Comments
ferventcoder
added a commit
that referenced
this issue
Jun 10, 2015
If for any reason the package is in failure mode, we should continue to let it be in failure mode and not mess up the state of the uninstall, since the package uninstall will be considered a failure.
ferventcoder
added a commit
that referenced
this issue
Jun 10, 2015
* stable: (GH-323) Do not run autouninstaller unless success Conflicts: src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When uninstalling, you can get similar output to the below if you have autouninstaller turned on. This is incorrect as once someone cancels the uninstall, it should completely stop further action on the uninstall, which is similar to how the install/upgrade both work.
The package packageName wants to run 'chocolateyuninstall.ps1'.
Note: If you don't run this script, the installation will fail.
Note: To confirm automatically next time, use '-y' or consider setting
'allowGlobalConfirmation'. Run 'choco feature -h' for more details.
Do you want to run the script?
_2_
Running auto uninstaller...
Auto uninstaller has _successfully_ uninstalled packageName from your machine.
packageName uninstall _not successful.
User cancelled powershell portion of installation for 'C:\ProgramData\Chocolatey\lib\packageName\tools\chocolateyuninstall.ps1'.
Use skip to install without run.
packageName has been _successfully uninstalled.
Chocolatey uninstalled 0/1 packages. 1 packages _failed_.
See the log for details (C:\ProgramData\Chocolatey\logs\chocolatey.log).
Failures
The portion for
packageName has been successfully uninstalledhas been handled by #315.The text was updated successfully, but these errors were encountered: