Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save software install location for future use #3315

Closed
2 tasks done
TheCakeIsNaOH opened this issue Sep 7, 2023 · 2 comments · Fixed by #3316
Closed
2 tasks done

Save software install location for future use #3315

TheCakeIsNaOH opened this issue Sep 7, 2023 · 2 comments · Fixed by #3316
Assignees
@TheCakeIsNaOH
Labels
5 - Released Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
2.3.0

Comments

@TheCakeIsNaOH
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Currently, Chocolatey CLI does not remember/save the software installation location found during package installation, it just prints the location out to the screen after package install/upgrade, e.g. Software installed to 'C:\ProgramData\chocolatey\lib\Wget\tools'

There are a number of issues here and for ChocolateyGUI that would need this information, but it is not currently saved.

Describe The Solution. Why is it needed?

Save the software installation path, if the package has one, into a file in .chocolatey, so it can be read later.

Additional Context

This is intended to be the backend/infrastructure issue, and then the linked issues would be unblocked once this added.

Related Issues
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 7, 2023
@TheCakeIsNaOH
(chocolatey#3315) Save software installation location
7af3b73 
Saves the software installation location into a ".softwareLocation"
file inside the package info directory. This allows Chocolatey CLI
or GUI to later retrieve it and display it to the user when listing
the details of locally installed package(s).
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Sep 7, 2023
Merged
10 tasks
@pauby
Copy link
Member

pauby commented Sep 7, 2023

What needs to be taken into account here is when Chocolatey CLI determines the installation location incorrectly, what is done with the information saved when it could be incorrect, and how it is made clear to the user that the installation location may be incorrect.

@gep13 gep13 added this to the 2.3.0 milestone Dec 14, 2023
@TheCakeIsNaOH TheCakeIsNaOH self-assigned this Jan 9, 2024
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#3315) Save software installation location
8f33c0c 
Saves the software installation location into a ".softwareLocation"
file inside the package info directory. This allows Chocolatey CLI
or GUI to later retrieve it and display it to the user when listing
the details of locally installed package(s).
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 26, 2024
@TheCakeIsNaOH @gep13
(chocolatey#3315) Save software installation location
929af7b 
Saves the software installation location into a ".softwareLocation"
file inside the package info directory. This allows Chocolatey CLI
or GUI to later retrieve it and display it to the user when listing
the details of locally installed package(s).
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 26, 2024
@TheCakeIsNaOH @gep13
(chocolatey#3315) Save software installation location
03faf4c 
Saves the software installation location into a ".softwareLocation"
file inside the package info directory. This allows Chocolatey CLI
or GUI to later retrieve it and display it to the user when listing
the details of locally installed package(s).
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 26, 2024
@TheCakeIsNaOH @gep13
(chocolatey#3315) Save package contents deployment location
c8c2c65 
Saves the location of where the contents of the Chocolatey package
(whether that is a native installer, or an extraction of a zip file, or
whatever else is in the package) is deployed to into a
".deploymentLocation" file inside the package info directory.

This allows Chocolatey CLI or GUI to later retrieve it and display it to
the user when listing the details of locally installed package(s).
gep13 added a commit that referenced this issue Apr 26, 2024
@gep13
Merge pull request #3316 from TheCakeIsNaOH/gh3315-remember-location
fa1111f 
(#3315) Save software installation location
@gep13 gep13 added 4 - Done Feature Issues that introduce new functionality to the project, instead of updating existing functionality labels Apr 26, 2024
gep13 added a commit that referenced this issue May 21, 2024
@gep13
(#3315) Update tests to match output
a547371 
As part of the work that was completed for this issue, the output was
changed from:

  Software installed to

to:

  Deployed to

This commit updates the assertion to make this match.
@pauby pauby changed the title Remember software installation location Save software install location for future use May 28, 2024
@gep13 gep13 mentioned this issue May 31, 2024
Open
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

(#3315) Save software installation location TheCakeIsNaOH/choco
4 participants
@gep13 @choco-bot @pauby @TheCakeIsNaOH