Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unpackself command #3426

Closed
2 tasks done
vexx32 opened this issue Apr 19, 2024 · 1 comment · Fixed by #3434
Closed
2 tasks done

Deprecate unpackself command #3426

vexx32 opened this issue Apr 19, 2024 · 1 comment · Fixed by #3434
Assignees
@gep13
Labels
5 - Released Deprecate Features or functionality that is being deprecated in favor of removing or replacing them in future.
Milestone
2.3.0

Comments

@vexx32
Copy link
Member

vexx32 commented Apr 19, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

-unpackself is presently only used at build time. We can deprecate this command and stop using it for the build process, and eventually remove it.

Describe The Solution. Why is it needed?

-unpackself works by embedding files that are already shipped alongside choco inside the executable, and unpacking them. However, these unpacked files are unsigned, as the build process signs them after building choco itself, so there is limited usefulness in the command.

Additional Context

No response

Related Issues

No response
@vexx32 vexx32 added this to the 2.3.0 milestone Apr 19, 2024
@vexx32 vexx32 added Improvement Deprecate Features or functionality that is being deprecated in favor of removing or replacing them in future. and removed Improvement labels Apr 19, 2024
This was referenced Apr 19, 2024
Closed
Open
@gep13 gep13 self-assigned this Apr 25, 2024
gep13 added a commit to gep13/choco that referenced this issue Apr 25, 2024
@gep13
(chocolatey#3426) Add deprecation notice for unpackself
749f7e3 
Based on internal conversations, while the unpackself command is
currently being used as part of the overall build process, it is not
something that is "required". So, rather than leave this command in
place, let's deprecate it, and then remove the command completely in
the next major version of Chocolatey CLI.

With this command removed, it will be necessary to change the build
process to sign the PowerShell files earlier in the build process than
they currently are, but it shouldn't impact on the end result at all.
@gep13 gep13 mentioned this issue Apr 25, 2024
Merged
10 tasks
AdmiringWorm added a commit that referenced this issue Apr 26, 2024
@AdmiringWorm
Merge pull request #3434 from gep13/deprecate-unpackself
efe9aa6 
(#3426) Add deprecation notice for unpackself
@gep13 gep13 added 4 - Done and removed 3 - Review labels Apr 26, 2024
@gep13 gep13 changed the title Deprecate -unpackself command Deprecate unpackself command May 28, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Deprecate Features or functionality that is being deprecated in favor of removing or replacing them in future.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

(#3426) Add deprecation notice for unpackself gep13/choco
3 participants
@gep13 @choco-bot @vexx32