-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer to remove actual package (*.install/*.portable) when removing meta/virtual package #735
Comments
@dtgm - by the way, meta packages are fully implemented and have been since day 1 of NuGet. It's virtual packages that are not fully implemented. |
You're right, when I stated It is also important to have this message since trying to uninstall the
and then |
Looks pretty good. Also puts out the first warning message with ANY install, upgrade or uninstall for packages that are in warning. |
This is related to #455. |
Split getting the package list from setting "all" items, such as upgrade all. This allows querying the list in other operations.
When uninstalling a meta package, a user may not realize they need to uninstall the actual package as well, such as a *.portable or *.intall. For instance, if a user uninstalls git package, they may not realize they have only removed the meta package and git.install and subsequently, Git for Windows are still installed. Provide a warning with a timeout offering to add the actual package to the list. If there is no response or the answer is no, add the actual package to the list of warnings for the package summary with an explanation on how to uninstall that package.
* stable: (doc) update CHANGELOG/nuspec (maint) formatting (GH-735) Remove actual when uninstalling meta (GH-455) Summary - log reason for warnings/errors (GH-735) split package list from all operation (GH-710) If timeout, inform user (maint) add review note (GH-689) Report install location (GH-755) Track more MSI information (maint) Template specs - restrict to Windows only
This is nearly the same as @dtgm does in his packages:
The message we would add is the following:
The prompt would timeout after 30 seconds with a default value of no. If no, provide the following text:
WARNING: To finish removing ___, please also run the command: `choco uninstall _____`
The text was updated successfully, but these errors were encountered: