-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.10 breaks Install-ChocolateyZipPackage (PSWindowsUpdate) #818
Comments
Looking at this closer, it appears that the extraction doesn't wait for the exit code, which means the process is returning before it is fully closed. |
Take a look at the debug output in your log file, you will see "7z exit code: " and no exit code. |
@Workshop2 can you provide log output here? You will find it in c:\programdata\chocolatey\logs (just grab from where you ran the command and down to the end result). If you can paste that to a gist and then link that here, that would be helpful to know what the error was (in your case it was silent) but I can not reproduce it yet. |
There are cases when the process has signalled it has exited, but it hasn't actually returned an exit code yet. Hold for 2 seconds to allow the process to fully exit before attempting to capture the exit code.
After downloading or FTPing a file, sleep for a second. When finishing running processes, do the same.
* stable: (GH-826) SYSTEM user always uses machine TEMP (GH-808) Allow silent args as array (GH-821) ValidExitCodes not recognized return 0 (GH-818) Allow disk to catch up - sleep (GH-822) Provide pending override and file wait (GH-818) Wait for processes to exit + 2 seconds (maint) formatting (GH-819) Fix - NotSilent install failure binding (GH-775) remove 7za (GH-775) Use 7z instead of 7za
#830 appears to be related. I believe this is good to go with the switch to 7zip full in 0.9.10.3. As a note, I was not able to reproduce this issue exactly, so please comment if you are still seeing this issue. |
What You Are Seeing?
Since 0.9.10.1 has been released this package no longer installs (even though everything is said to be working). This package seems to use
Install-ChocolateyZipPackage
What is Expected?
I expected to see the the PS files to be installed to
(Join-Path $PSHome "Modules\PSWindowsUpdate")
but nothing gets copiedHow Did You Get This To Happen? (Steps to Reproduce)
Run this script on a 2008R2 machine
Output Log
Broken log:
Working log from 0.9.9.12
The text was updated successfully, but these errors were encountered: