Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger default log file size and retention #852

Closed
DarwinJS opened this issue Jul 6, 2016 · 8 comments
Closed

Larger default log file size and retention #852

DarwinJS opened this issue Jul 6, 2016 · 8 comments
Assignees
Milestone

Comments

@DarwinJS
Copy link
Contributor

DarwinJS commented Jul 6, 2016

We are starting to use Chocolatey for code deployment due to the limitations of NuGet (mainly to call a script from inside the package when processing OUTSIDE of Visual Studio).

This allows our code deploy packages to be called where we have no orchestration to trigger the install script (e.g. our developer workstations do not have Chef nor octopus installed).

I am making sure each and every file copy gets logged so that root cause is easy if a code deploy in production goes wrong.

In one of my packages there are so many files that this overflows all 11 chocolatey log files and I can't see the beginning of the log.

I understand that this is not necessarily a use case that chocolatey was designed around - but Chocolatey is very useful for code deploys for us and I think others may find the same.

It would be helpful if the size limit on each log file were higher by default. 1 MB is a pretty small limit.

If the default size of each could be, say, 100 MB, then I may not need any additional configuration controls. I think this would be the preferred option as I would not have to reconfigure the default chocolatey install.

If the size must remain 1MB, it would be helpful to have configuration control over how many old versions are kept.

@ferventcoder
Copy link
Member

Let's go with larger defaults of 10MB and allow it to be configurable on config settings. Sound good?

@ferventcoder
Copy link
Member

10MB default and 50 files kept around

@ferventcoder ferventcoder added this to the 0.9.10.4 milestone Jul 6, 2016
@DarwinJS
Copy link
Contributor Author

DarwinJS commented Jul 6, 2016

Sure - if you're going to bother exposing a config setting, maybe also expose both values?

Some regulated environments might have need to keep a ridiculous amount of history around - not my scenario - what you have proposed is perfectly fine for my current scenario.

@ferventcoder
Copy link
Member

Sure - if you're going to bother exposing a config setting, maybe also expose both values?

That was the plan. That's why I used the term "settings" ;)

@ferventcoder
Copy link
Member

ferventcoder commented Jul 6, 2016

Just typing too fast and didn't get the number of files into the first response.

@DarwinJS
Copy link
Contributor Author

DarwinJS commented Jul 7, 2016

Cool - all sounds good.

@ferventcoder ferventcoder self-assigned this Jul 13, 2016
ferventcoder added a commit that referenced this issue Jul 24, 2016
By default, keep 50 10MB log files instead of 10 1MB files.
ferventcoder added a commit that referenced this issue Jul 24, 2016
* stable:
  (maint) Skip log PowerShell resource assembly failures
  (GH-871) Fix - Uninstall zip: Path is empty string
  (maint) remove unused import
  (GH-854) Reset Exit Code between package runs
  (GH-852) Bump up the default log sizes
  (GH-867) NuGet.Core Errors Exit Code 1
  (GH-853) Handle null values better
  (GH-836) Fix - Use 32 bit 7zip
  (GH-847) Tab Completion Enhancements
  (GH-857) Fix - Sometimes paths contain null chars
@ferventcoder ferventcoder changed the title Larger default log file size or configuration control over retention Larger default log file size and retention Aug 3, 2016
@ferventcoder
Copy link
Member

@DarwinJS I pushed the pulling values from configuration to #890. I didn't want to lose track of the latter part but it is a bit more involved than I will be able to tackle in the timeframe for 0.9.10.4 release.

@DarwinJS
Copy link
Contributor Author

DarwinJS commented Aug 3, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants