(GH-1099) Change buffer for FTP downloads to 1MiB #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer size changes from 1KiB to 1MiB. This will make FTP downloads more performant, and shift the `Get-FtpFile` implementation to match `Get-WebFile`.
|
I apologise for the messing around with commits to get this going, particularly since it's so trivial. I had to modify the email address on my commits to comply with my organization's prerequisites. |
|
Note that to the best of my knowledge this is complete. Let me know if there is anything further you'd like me to do on this request. |
|
Just a minor nitpick - surround the GH issue with parenthesis. As in |
ferventcoder
changed the title
|
No probs, I'll change what I do from here on in.
Change whatever you like for whatever reason. I'll probably learn something
if a change is necessary.
…On Sun, 22 Jan 2017 at 10:32 am, Rob Reynolds ***@***.***> wrote:
Just a minor nitpick - surround the GH issue with parenthesis. As in (GH-1099)
Change buffer for FTP download to 1MB instead of GH-1099 Change buffer
for FTP download to 1MB. I'm likely to make this change for you if are
happy with what you have here and don't mind me adjusting the commit
messages.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwW6xBfzhU9snMzRFsdUImA2xC1cI8bks5rUpV7gaJpZM4LW5_n>
.
|
|
Merged into stable at 5d25060 |
|
Thanks for your contributions! This will be in the next release of Chocolatey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer size changes from 1KiB to 1MiB. This will make FTP downloads more performant, and shifts the
Get-FtpFileimplementation to matchGet-WebFilein this detail.Closes #1099