Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1056) Add support for automatic decompression to Get-WebFile #1188

Closed
wants to merge 1 commit into from
Closed

(GH-1056) Add support for automatic decompression to Get-WebFile #1188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/chocolatey.resources/helpers/functions/Get-WebFile.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ param(
$explicitProxy = $env:chocolateyProxyLocation
$explicitProxyUser = $env:chocolateyProxyUser
$explicitProxyPassword = $env:chocolateyProxyPassword
$explicitProxyBypassList = $env:chocolateyProxyBypassList
$explicitProxyBypassList = $env:chocolateyProxyBypassList
$explicitProxyBypassOnLocal = $env:chocolateyProxyBypassOnLocal
if ($explicitProxy -ne $null) {
# explicit proxy
Expand Down Expand Up @@ -159,6 +159,7 @@ param(
$req.AllowAutoRedirect = $true
$req.MaximumAutomaticRedirections = 20
#$req.KeepAlive = $true
$req.AutomaticDecompression = [System.Net.DecompressionMethods]::GZip -bor [System.Net.DecompressionMethods]::Deflate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this pick up both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should. DecompressionMethods are flags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is helpful - works in .net 2+ https://msdn.microsoft.com/en-us/library/system.net.decompressionmethods(v=vs.80).aspx

$req.Timeout = 30000
if ($env:chocolateyRequestTimeout -ne $null -and $env:chocolateyRequestTimeout -ne '') {
Write-Debug "Setting request timeout to $env:chocolateyRequestTimeout"
Expand Down