(GH-1546) Fix undefined zipFileContentPath var #1561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this was merged in 93c3394 , so the pull request can be closed? |
|
@lebdron long story short... I messed something up during the merging process, and I haven't yet finished fixing it yet 😢 I will be closing this PR, since as you mentioned, this has now been merged in, but if you could hold off on doing that, I will do that as I complete the necessary steps. Thanks again for noticing and submitting this PR, we very much appreciate it! |
|
This was merged here: 93c3394 |
|
@lebdron thank you again for taking the time to do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
zipFileContentPath->zipContentFile, so thatTest-Path -Pathinput is notnullCloses #1546 , and probably also closes #1550 .Tested with
mingwpackage, please also test before merge.