Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom headers downloading files #246

Closed
wants to merge 1 commit into from

Conversation

patrickmaurer
Copy link

Changes made by @ewilde taken from chocolatey-archive/chocolatey/pull/171

@ferventcoder
Copy link
Member

Hi @patrickmaurer - can you please review our CONTRIBUTING.md document and adjust this PR for the changes you will need to make to the commit message (including filing an issue in this code base so you can reference it in your commit), signing the CLA and other such items? Thanks!

@ferventcoder
Copy link
Member

The code itself looks fine.

@ferventcoder
Copy link
Member

@patrickmaurer have you had an opportunity to review my feedback and respond?

@patrickmaurer
Copy link
Author

Well the CLA thing frightened my a bit because of

  1. the code isn't mine but from @ewilde (Support for custom headers downloading files chocolatey-archive/chocolatey#171)
  2. the CLA legalese itself didn't make me feel very comfortable, I also don't like to disclose all my personal details

@ferventcoder
Copy link
Member

That's fair - I don't share CLA details with anyone. Unless litigation comes up, then I would share those details, but only selectively. That's an extreme, I don't expect anything of the sort.

Perhaps @ewilde could provide the PR instead? :/

@ewilde
Copy link
Contributor

ewilde commented Jun 3, 2015

@ferventcoder yep happy to do that. Will review the contributing.md and create a new PR

@ferventcoder
Copy link
Member

Closed via #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants