(#2754) Add support for detecting newer Windows versions #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
54b9e14
to
fddfb31
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
fddfb31
to
70296c4
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
70296c4
to
ffb504e
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
2 times, most recently
from
ad4e68f
to
ec36338
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
ec36338
to
23c32de
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
23c32de
to
298025c
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
298025c
to
4bb8167
Compare
TheCakeIsNaOH
force-pushed
the
platform-name
branch
from
4bb8167
to
a67b3de
Compare
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022. Which will allow the OS_NAME environment variable to be set correctly on those operating systems.
|
@TheCakeIsNaOH I have taken this for a spin across 5 different VM's and happy to say that this is working as expected! Thank you very much for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
Motivation and Context
See #2754
Testing
N/A
Change Types Made
Related Issue
Fixes #2754
Change Checklist