(#2860) Add new PowerShell helper function for acquiring paths from private variables #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
new-path-helper
branch
from
31dd40a
to
8c68cb6
Compare
AdmiringWorm
force-pushed
the
new-path-helper
branch
from
8c68cb6
to
8eab012
Compare
gep13
requested changes
Oct 19, 2022
src/chocolatey.resources/helpers/functions/Get-ChocolateyPath.ps1
Outdated
Show resolved
Hide resolved
src/chocolatey.resources/helpers/functions/Get-ChocolateyPath.ps1
Outdated
Show resolved
Hide resolved
AdmiringWorm
force-pushed
the
new-path-helper
branch
from
8eab012
to
5c47d6c
Compare
AdmiringWorm
force-pushed
the
release/1.2.0
branch
from
3412ab3
to
baac40f
Compare
This commit adds a new PowerShell helper to Chocolatey CLI that allows maintainers to acquire the paths that we have stored as private/internal environment variables. This allows maintainers to still make use of these variables through this new helper while still retaining the ability to push the package to Chocolatey Community Repository.
This commit adds the `--pin` option to the list of available options in the table completion. The pin option was added to the install and upgrade command in this release.
AdmiringWorm
force-pushed
the
new-path-helper
branch
from
641e6cc
to
dcf859e
Compare
|
@AdmiringWorm thanks for getting this updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request adds a new PowerShell helper that can be used going forward to get access to the private environment variable
PackagePath, as well as to get the installation directory of Chocolatey CLI.Motivation and Context
There is no direct replacement for using the environment variable
$env:PackagPathand$env:ChocolateyPackagePaththat can be used by maintainers (at least on Chocolatey Community Repository.).As such it makes sense to add this ability to maintainers through the use of a new cmdlet that can be used.
Testing
But manual testing can be done with:
tests/packages/test-chocolateypath.choco install <PATH-TO-NUPKG>choco uninstall test-chocolateypathChange Types Made
Related Issue
Fixes #2860
Change Checklist