Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URLs in repository README file #2888

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

agabrys
Copy link
Contributor

@agabrys agabrys commented Nov 7, 2022

Description Of Changes

Update the Troubleshooting and FAQ URLs. The correct locations were taken from the SUBMITTING-ISSUES.md file.

Motivation and Context

Remove confusion - point users to valid pages.

Testing

I clicked the changed links.

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.

Doc fix.

Related Issue

N/A

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

gep13
gep13 previously approved these changes Nov 7, 2022
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Nov 7, 2022

@agabrys thank you very much for taking the time to fix these up! Really appreciate it!

Update the `Troubleshooting` and `FAQ` URLs. The correct locations were
taken from the `SUBMITTING-ISSUES.md` file.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Nov 7, 2022

@agabrys I took the liberty of changing your commit message slightly in make it in-keeping with how we normally do things, but other than that, this looks great. I will get this merged in once the CI builds pass.

@agabrys agabrys changed the title Update broken URLs in Submitting Issues (doc) Fix broken URLs in README.md Nov 7, 2022
@gep13 gep13 merged commit 7e23ae6 into chocolatey:develop Nov 7, 2022
@gep13 gep13 changed the title (doc) Fix broken URLs in README.md Fix broken URLs in README.md Jan 24, 2023
@gep13 gep13 changed the title Fix broken URLs in README.md Fix broken URLs in repository README file Jan 24, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants