Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2345) This prevents unintended space(s) being passed #2951

Closed
wants to merge 1 commit into from

Conversation

RedBaron2
Copy link

@RedBaron2 RedBaron2 commented Dec 28, 2022

Description Of Changes

This is intended to prevent unintended space(s) showing up in the installation of a package (ex: totalcommander package)

Motivation and Context

#2345 This issue is preventing Total Commander from being the latest version on the Community Feed

Testing

Operating Systems Testing

The operating systems this has been tested on

  • Windows 11
  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #

unintended space showing up in some cases.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pauby
Copy link
Member

pauby commented Dec 29, 2022

@RedBaron2 Please don't tag people in Pull Requests.

Can you also have a read of the Contributing doc particular Commits?

@RedBaron2 RedBaron2 changed the title (Install-ChocolateyInstallPackage) This prevents unintended space(s) being passed (#2345) This prevents unintended space(s) being passed Dec 31, 2022
@gep13
Copy link
Member

gep13 commented May 7, 2024

@RedBaron2 thank you for taking the time to submit this PR, and apologies for the time it has taken to come back to you about it.

In the end, there were 3 PR's that attempted to address this problem, and based on a review by @corbob we have opted to move forward with a different PR:

#3113

As such, I am going to go ahead and close out this PR. Thank you again for raising this PR, and bringing additional focus on the underlying problem.

@gep13 gep13 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants