Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2986) Strip config list down to just config #3067

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Mar 15, 2023

Description Of Changes

  • Remove deprecation messages regarding config list as they are no longer relevant
  • Remove non-config-related output from the config command and service.

Motivation and Context

We have other commands for listing features, sources, apikeys, etc. Config can finally just be config. Long-awaited deprecation.

Testing

  1. Build and run with config list
  2. Ensure only config values and nothing else is listed
  3. Run ConfigCommand tests and ensure nothing breaks

Operating Systems Testing

Tested on Win11

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
    • I don't think this will happen until the 2.x stable release though?
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #2986

@vexx32 vexx32 force-pushed the 2986-break-config-list branch 2 times, most recently from 73b718d to 9e5a5d8 Compare March 15, 2023 20:46
We have other commands for listing features, sources, apikeys, etc.
Config can finally just be config.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 8021903 into chocolatey:develop Mar 16, 2023
@gep13
Copy link
Member

gep13 commented Mar 16, 2023

@vexx32 thank you for getting this sorted out!

@vexx32 vexx32 deleted the 2986-break-config-list branch March 16, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

choco config list should only include information about config
2 participants