(#3292) Ensure pre-release flag is used for parent lookup #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
force-pushed
the
bugfix/3292-Unable-to-upgrade-package-if-p
branch
from
b58498e
to
3d10959
Compare
These changes makes sure that we pass along any pre-release flag when there is a pre-release package that is a parent of one of the packages that we are installing, and to verify that the results is not null before we attempt to use it. This ensures that pre-release only packages can be found when we look up the parent, and if by some reason the package can not be found we do not throw an undesired null exception in this case.
gep13
force-pushed
the
bugfix/3292-Unable-to-upgrade-package-if-p
branch
from
3d10959
to
235c4b7
Compare
|
@AdmiringWorm thank you for digging in and getting this fixed! |
joaka1987
approved these changes
Apr 15, 2024
joaka1987
approved these changes
Apr 15, 2024
P7470
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
These changes makes sure that we pass along any pre-release flag
when there is a pre-release package that is a parent of one of the
packages that we are installing, and to verify that the results is not
null before we attempt to use it.
Motivation and Context
This ensures that pre-release only packages can be found when we
look up the parent, and if by some reason the package can not be
found we do not throw an undesired null exception in this case.
Testing
chocolatey-core.extensionversion 1.3.3 usingchoco install chocolatey-core.extension --version 1.3.3firefox-devusingchoco install firefox-dev --prechocolatey-core.extensionto latest version usingchoco upgrade chocolatey-core.extensionOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3292