(#725) Wait for child processes to complete #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for installers which exit immediately, and spawn lingering child processes, which may carry on additional installation tasks. Solution first queries for child processes whose parent process ID matches the installer process. Then, recursively queries for other active processes related to those children. Finally, wait for each process to exit.
|
|
||
| Write-Debug "Searching for any active children to process ($($Id))" | ||
|
|
||
| $children = Get-WmiObject -Class Win32_Process -Filter "ParentProcessID=$($Id)" |
There was a problem hiding this comment.
Interesting. Is there any issues with using this? I would almost want to wrap this in a try catch, so that if it fails it doesn't cause any issues.
|
ping @dekalinowski |
|
I receive your ping. I will follow up within the next day on #725 |
|
As reported in #725, I confirm v0.9.10.2 of Chocolatey resolves this original issue. This pull-request is not needed. |
|
This may still be necessary. Reopening. cc @boyan-kostadinov |
|
|
gep13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #725
Fix for installers which exit immediately, and spawn lingering child
processes, which may carry on additional installation tasks.
Solution first queries for child processes whose parent process ID
matches the installer process. Then, recursively queries for other
active processes related to those children. Finally, wait for each
process to exit.