Fix clang-tidy issues raised in PLMC PR

cholla-hydro · Jun 21, 2023 · 11b855f · 11b855f
1 parent 266e51d
commit 11b855f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/global/global.cpp b/src/global/global.cpp
@@ -109,7 +109,7 @@ const std::set<const char *> optionalParams = {
 int is_param_valid(const char *param_name)
 {
   // for (auto optionalParam = optionalParams.begin(); optionalParam != optionalParams.end(); ++optionalParam) {
-  for (auto optionalParam : optionalParams) {
+  for (const auto *optionalParam : optionalParams) {
     if (strcmp(param_name, optionalParam) == 0) {
       return 1;
     }

diff --git a/src/reconstruction/plmc_cuda_tests.cu b/src/reconstruction/plmc_cuda_tests.cu
@@ -39,8 +39,8 @@ TEST(tHYDROPlmcReconstructor, CorrectInputExpectCorrectOutput)
 
   // Setup host grid. Fill host grid with random values and randomly assign maximum value
   std::vector<double> host_grid(nx * ny * nz * n_fields);
-  for (size_t i = 0; i < host_grid.size(); i++) {
-    host_grid.at(i) = doubleRand(prng);
+  for (Real &val : host_grid) {
+    val = doubleRand(prng);
   }
 
   // Allocating and copying to device
@@ -172,8 +172,8 @@ TEST(tMHDPlmcReconstructor, CorrectInputExpectCorrectOutput)
 
   // Setup host grid. Fill host grid with random values and randomly assign maximum value
   std::vector<double> host_grid(n_cells_grid);
-  for (size_t i = 0; i < host_grid.size(); i++) {
-    host_grid.at(i) = doubleRand(prng);
+  for (Real &val : host_grid) {
+    val = doubleRand(prng);
   }
 
   // Allocating and copying to device