-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dust Build #209
Dust Build #209
Conversation
Conflicts: cholla-tests-data src/grid/initial_conditions.cpp
This mostly looks good to me, with a couple recommended changes: |
Oh, and can you please confirm that all existing tests all still pass with this code addition? |
This might be tricky. PR #199 unintentionally removed the system test data submodule. Until that is back system tests don't have data to compare to. That was @ojwg's PR and I have alerted him to the issue. |
…tions to the Clouds() initial conditions function.
ca4f7d7 removed the dust build-specific modifications to |
Okay, I manually downloaded and copied the system tests data from #198 (the last PR before it was deleted) into my repo, and verified that the tests pass for the hydro and dust builds. |
Contains code for dust model (sputtering only) that can be turned on using the
DUST
build type and initial condition/boundary condition functions (Grid3D::Clouds()
andGrid3D::Wind_Boundary()
) for cloud in wind tunnel set up