Add circularly polarized alfven wave test #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaddy
force-pushed
the
dev-mhdPolarizedAlfvenWave
branch
3 times, most recently
from
6174a4d
to
765aa96
Compare
- Added new `polarization` parameter for this test - New `Circularly_Polarized_Alfven_Wave` initial condition type. Note that this test has a very limited set of initial conditions where it is meaningful and so most of them are hard coded and the rest are checked wit assert statements - Lowered the maximum divergence to 1E-9 after discussing with Chris White of the Flatiron institute who's an Athena dev. - Added new system tests for the circularly polarized alfven wave - New parameter file for the circularly polarized alfven wave - Minor refactor of MHD utils to make more consistent use of the `computeMagneticEnergy` function.
bcaddy
force-pushed
the
dev-mhdPolarizedAlfvenWave
branch
from
765aa96
to
7f49dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polarizationparameter for this testCircularly_Polarized_Alfven_Waveinitial condition type. Note that this test has a very limited set of initial conditions where it is meaningful and so most of them are hard coded and the rest are checked with assert statementscomputeMagneticEnergyfunction.