Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 11 clang-tidy checks #293

Merged
merged 18 commits into from
Jun 22, 2023
Merged

Fix 11 clang-tidy checks #293

merged 18 commits into from
Jun 22, 2023

Commits on Jun 21, 2023

  1. Append make type to clang-tidy log files

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    99f325a View commit details
    Browse the repository at this point in the history

  2. Fix & Enable modernize-loop-convert tidy check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    34a0ee3 View commit details
    Browse the repository at this point in the history

  3. Fix & enable modernize-use-default-member-init check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    54f87ab View commit details
    Browse the repository at this point in the history

  4. Fix & Enable performance-faster-string-find check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8269b69 View commit details
    Browse the repository at this point in the history

  5. Fix & Enable performance-for-range-copy check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3507e35 View commit details
    Browse the repository at this point in the history

  6. Fix & enable use-auto checks. Remove alias to device vector 

    Fixed and enable modernize-use-auto and its aliad hicpp-use-auto.

Removed unsafe alias to a DeviceVector pointer in io.cpp
    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e0bf3d4 View commit details
    Browse the repository at this point in the history

  7. Enable performance-inefficient-vector-operation check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    48ca296 View commit details
    Browse the repository at this point in the history

  8. Fix & Enable performance-unnecessary-value-param check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    80084af View commit details
    Browse the repository at this point in the history

  9. Update jenkinsfile for new clang-tidy log names

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f04168d View commit details
    Browse the repository at this point in the history

  10. Add make type info to message that prints after clang-tidy runs

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2b038c8 View commit details
    Browse the repository at this point in the history

  11. Enable readability-const-return-type clang-tidy check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8e3e847 View commit details
    Browse the repository at this point in the history

  12. Fix & Enable readability-simplify-boolean-expr check

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ab2e98f View commit details
    Browse the repository at this point in the history

  13. Enable google-build-namespaces check 

    Also, it's alias cert-dcl59-cpp
    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f9c2a1c View commit details
    Browse the repository at this point in the history

  14. Fix & Enabled cert-err58-cpp

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d59c61c View commit details
    Browse the repository at this point in the history

  15. Fix rebase error

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3a58490 View commit details
    Browse the repository at this point in the history

  16. Permanently disable cert-err58-cpp check 

    This check provides minimal benefit to us and flags every single gtest
TEST macro as failing so I've disabled it.
    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5f73ad4 View commit details
    Browse the repository at this point in the history

  17. Formatting

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    266e51d View commit details
    Browse the repository at this point in the history

  18. Fix clang-tidy issues raised in PLMC PR

    @bcaddy
    bcaddy committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    11b855f View commit details
    Browse the repository at this point in the history