Turn on clang-tidy check for function naming and change function names to pass check #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on readability-identifier-naming check
…on readability-identifier-naming check
|
All the MHD and testing stuff looks good to me. |
ojwg
suggested changes
Jul 11, 2023
| ddi_(sqr(double(n[0] - 1) / (hi[0] - lo[0])) / 6.0), | ||
| ddj_(sqr(double(n[1] - 1) / (hi[1] - lo[1])) / 6.0), | ||
| ddk_(sqr(double(n[2] - 1) / (hi[2] - lo[2])) / 6.0), | ||
| ddi_(Sqr(double(n[0] - 1) / (hi[0] - lo[0])) / 6.0), |
There was a problem hiding this comment.
sqrt is a library call, so this name change will break the code.
There was a problem hiding this comment.
Maybe I'm misunderstanding something, but I thought those were calls to an inline function defined in line 7 of this file that returns the square of the argument?
|
I think this one is good to go once it's merged with the updated version of dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason that's not currently clear to me, clang-tidy only catches some instances of function names not conforming to the
Upper_Snake_Casenaming convention that we've chosen. I've corrected all of the functions that the check was failing for (and others that I happened to catch while doing this) and the check now passes.For the most part, it was straightforward to choose new versions of the function names to conform to our naming standard, but there are a few cases that I could use a second opinion on. In particular, there were a few function names in models/disk_ICs.cpp that I didn't understand the meaning of, so the new names that I gave them might not be the best.