Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GPU Error Checking Function #350

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Consolidate GPU Error Checking Function #350

merged 5 commits into from
Dec 8, 2023

Commits on Nov 27, 2023

  1. Remove accidentally committed file

    @bcaddy
    bcaddy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4477747 View commit details
    Browse the repository at this point in the history

  2. Consolodate GPU error checking functions 

    Consolodate all GPU error checking functions and macros into one
overloaded function with one overload for CUDA/HIP errors and one for
CUFFT/HIPFFT errors. That one doesn't use any macros and supports all
the usual usage modes. It does utilize the
`experimental::source_location` class. That class is supported on all
compilers that we use or expect others to use but if it doesn't work
for you then commenting out the relevant lines should be sufficient.

Replaced all calls to `CHECK`, `CudaSafeCall`, `CudaCheckError`, and
`gpErrchk` with `GPU_Error_Check`.
    @bcaddy
    bcaddy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9869555 View commit details
    Browse the repository at this point in the history

  3. Add missing error checks to some cudaMallocs 

    Some already had error checks on the next line but now they're all
wrapped as is standard in the rest of the code
    @bcaddy
    bcaddy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    971bacf View commit details
    Browse the repository at this point in the history

  4. Make GPU error checking on by default 

    The CUDA_ERROR_CHECK macro that turns on error checking has been
deprecated in favor of the new DISABLE_GPU_ERROR_CHECKING macro which
disable error checking. Error checking is now on by default unless
compiled with the DISABLE_GPU_ERROR_CHECKING macro.
    @bcaddy
    bcaddy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c5e35a6 View commit details
    Browse the repository at this point in the history

  5. Add HIPifly macros needed for GPU error checking

    @bcaddy
    bcaddy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cdbed5d View commit details
    Browse the repository at this point in the history