Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the cooling-choice a runtime parameter #415

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Make the cooling-choice a runtime parameter #415

wants to merge 21 commits into from

Commits on Jul 24, 2024

  1. Refactored ParameterMap initialization 

    Previously it was initialized inside of Parse_Params and destroyed
there. Now we initialize it outside of the function so that we can do
other things with it.
    @mabruzzo
    mabruzzo committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b391b35 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. first step towards runtime-configurable chemistry.

    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1a4ef75 View commit details
    Browse the repository at this point in the history

  2. another step towards runtime-configuration of chemistry.

    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    29fbc9e View commit details
    Browse the repository at this point in the history

  3. yet another step towards runtime-configuration of chemistry.

    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8ae8ee5 View commit details
    Browse the repository at this point in the history

  4. Removed most remaining CLOUDY_COOL and COOLING_GPU macros from the so… 

    …urce files

Along the way, I removed TEMP_FLOOR and DENS_FLOOR. These were not
actually getting used for anything meaningful (they were left over from
when the old FLOOR-APPLICATION system)
    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    dd74f42 View commit details
    Browse the repository at this point in the history

  5. moved the location where we check for unused parameters.

    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b4a8917 View commit details
    Browse the repository at this point in the history

  6. fix a few assorted things.

    @mabruzzo
    mabruzzo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    51709b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. address clang-tidy issues.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    58f92e2 View commit details
    Browse the repository at this point in the history

  2. make format.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    de38ca8 View commit details
    Browse the repository at this point in the history

  3. a bunch of refactoring.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    1d2583f View commit details
    Browse the repository at this point in the history

  4. make it possible to enable photoelectric heating.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    e22f16f View commit details
    Browse the repository at this point in the history

  5. minor refactor.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    bd3f1af View commit details
    Browse the repository at this point in the history

  6. introducing new tests for parameter-tables.

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7c3b984 View commit details
    Browse the repository at this point in the history

  7. intermediate commit

    @mabruzzo
    mabruzzo committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    bdff8ab View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. another incremental commit.

    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ed7b425 View commit details
    Browse the repository at this point in the history

  2. significant cleanup

    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2b0eddd View commit details
    Browse the repository at this point in the history

  3. some simplification.

    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ff2f2db View commit details
    Browse the repository at this point in the history

  4. introduce the Enforce_Table_Content_Uniform_Access_Status method.

    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c73c2fb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'parameter-tables' into cooling-choice-photoelectric-hea… 

    …ting
    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9c666ba View commit details
    Browse the repository at this point in the history

  6. we now raise an error if the [chemistry] parameter group gets passed … 

    …unused arguments.
    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    944a959 View commit details
    Browse the repository at this point in the history

  7. adding ability to specify more parameters.

    @mabruzzo
    mabruzzo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b6feec3 View commit details
    Browse the repository at this point in the history