[wip] add DFR chapter #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Directory structure | ||
| In order to facilitate reusability, one must plan for it. Often the hardest | ||
| part about modularity is becoming comfortable with determining where the | ||
| boundries are. As a rule of thumb: any piece of logic that doesn't directly |
yoshuawuyts
force-pushed
the
creating-components.md
branch
from
426abb7
to
17e8efa
Compare
| const html = require('choo/html') | ||
| const Form = require('../components/form') | ||
|
|
||
| const renderForm = Form(formInput, { |
There was a problem hiding this comment.
I think you mean to use a function signature here, ie const renderForm = (formInput) => Form(formInput, {
yoshuawuyts
force-pushed
the
creating-components.md
branch
from
17e8efa
to
e2a81db
Compare
yoshuawuyts
force-pushed
the
creating-components.md
branch
from
e2a81db
to
5a497ac
Compare
|
Yeah cool, addressed all notes - per @timwis's suggestion on IRC let's merge and edit from there - neat to like have this available already ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured it'd be nice to highlight how to design reusable components; further zooming in on @maxogden's comments in IRC
This provides the potential to zoom into the design decisions underlying
choo; the full interop it has with any methods that operates on raw DOM and highlighting patterns to prevent completely getting tangled up in another framework, yet again.Also @shama got me a bit worried about completely buying into frameworks haha (as per choojs/choo#152) - feel like having a guide might align mindsets or smth like that.
Anyway this is very much wip - but I'm off to bed so sharing what I got so far. Night!