-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 #127
Merged
Merged
3.0 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes ======= - add hook handlers - add effect composition - add noFreeze option Commits ======= - fixup! fix toString() - fixup! use assert instead of throw - fixup! fix reducers - fixup! work on done callbacks - fixup! more callback work - fixup! woooh fixed effects errs - fixup! wrap up stuff
architecture: use barracks
fixup! freeze state & rename app ns to location
Change view arguments
Rename action param to data
docs: restructure
* Barracks must get an initial state or state.location is undefined * Replaces document.addEventListener w/ pkg handling existing ready doc
* Barracks will always return a new object https://github.com/yoshuawuyts/barracks/blob/11d3c6d1822beadce0251279f9bc8370c569ea5e/index.js#L144
* proxyquire (pq) replaces choo's sheet-router/history with a mock * pq-universal replaces pq w/ pqify in the browser * magic!
As the test suite grows it's bad for debugging to leak tons of elements onto document.body. In order to concisely append/remove on the tests' "end" event, we need to make sure the root tagName doesn't change. If it does, the `tree` returned from `app.start` will no longer be the root node and the removal fn will throw.
Run all the tests via Electron
deps: bump document ready version
deps: bump to barracks 8
changelog: 3.0.0
Readme fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
42 commits, 1k additions, 800 removals, a bunch of breaking changes. Cheers to all of you; I think
v3
is ready! β¨Closes #42 πππππ