don't URL encode slash in [githubactionsworkflow] badge

chris48s · Jun 26, 2023 · 61491f9 · 61491f9
1 parent 53efe52
commit 61491f9
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/services/github/github-actions-workflow-status.service.js b/services/github/github-actions-workflow-status.service.js
@@ -78,11 +78,13 @@ export default class GithubActionsWorkflowStatus extends BaseSvgScrapingService
   }
 
   async fetch({ user, repo, workflow, branch, event }) {
+    const workflowPath = workflow
+      .split('/')
+      .map(el => encodeURIComponent(el))
+      .join('/')
     const { message: status } = await this._requestSvg({
       schema,
-      url: `https://github.com/${user}/${repo}/actions/workflows/${encodeURIComponent(
-        workflow
-      )}/badge.svg`,
+      url: `https://github.com/${user}/${repo}/actions/workflows/${workflowPath}/badge.svg`,
       options: { searchParams: { branch, event } },
       valueMatcher: />([^<>]+)<\/tspan><\/text><\/g><path/,
       httpErrors: {

diff --git a/services/github/github-actions-workflow-status.tester.js b/services/github/github-actions-workflow-status.tester.js
@@ -64,3 +64,17 @@ t.create('valid workflow (with event)')
     label: 'build',
     message: isWorkflowStatus,
   })
+
+t.create('valid workflow with / in workflow name')
+  .get('/chris48s/blogmarks/pages/pages-build-deployment.json')
+  .expectBadge({
+    label: 'build',
+    message: isWorkflowStatus,
+  })
+
+t.create('valid workflow with special chars in workflow name')
+  .get('/chris48s/test-workflows/special%3A%26chars.yml.json')
+  .expectBadge({
+    label: 'build',
+    message: isWorkflowStatus,
+  })