Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few dashboard card improvements #93

Closed
santoshbmath opened this issue Apr 12, 2021 · 2 comments · Fixed by #77
Closed

Few dashboard card improvements #93

santoshbmath opened this issue Apr 12, 2021 · 2 comments · Fixed by #77
Labels
enhancement New feature or request

Comments

@santoshbmath
Copy link

Is your proposal related to a problem?

No, but suggesting few improvements.

Describe the solution you'd like

Here are few enhancements i am suggesting,

  1. Change minimize icon to close icon as it closes/removes the card from the dashboard.
  2. Move "Settings" icon in card header along with close icon.
  3. Remove "Balance...." row altogether as the symbol is already present in header.
  4. Club action and current price in one section. Because based on current price action will be updated.
@santoshbmath santoshbmath added the enhancement New feature or request label Apr 12, 2021
@chrisleekr
Copy link
Owner

Thanks for suggestions.

  1. Change minimize icon to close icon as it closes/removes the card from the dashboard.

Oh, good point. I will change to X rather than -.

  1. Move "Settings" icon in card header along with close icon.

Ok, good point again.

  1. Remove "Balance...." row altogether as the symbol is already present in header.

Well, if I have multiple coins and I should open the Account Balance accordion and find the coin balance. I think we can keep it to make less mouse click?

  1. Club action and current price in one section. Because based on current price action will be updated.

I tried to put the current price in the relevant sections as below. Are you saying, remove those current price rows and put with Action row? Wouldn't be annoying if you keep moving your eyes to compare with other prices?
image

@chrisleekr chrisleekr linked a pull request Apr 19, 2021 that will close this issue
Updated for monitoring multiple coins simultaneously and other improvements #77
Merged
@chrisleekr
Copy link
Owner

Hey guys,

I have updated the frontend in the pull request for points 1 and 2.

image

Points 3/4 will not be fixed.
This issue will be closed once the PR is merged.

@chrisleekr chrisleekr mentioned this issue Apr 24, 2021
Merged
chrisleekr added a commit that referenced this issue May 21, 2021
@chrisleekr @garyng
Updated for monitoring multiple coins simultaneously and other improv…
f535b18 
…ements (#77)

- Updated frontend to display version - #59
- Support monitoring multiple coins simultaneously - #77
- Added docker-stack.yml for the Portainer - @hipposen
- Fixed precision issues for some FIAT - #90
- Improved frontend & settings UI - #93 #85
- Support all symbols - #104
- Added stop loss feature - #99
- Stabilised Local Tunnel, cronjob and Binance WebSocket
- Prevented to place new order when the API limit reached - #163
- Added NPM task for building docker image on Windows by @garyng - #175

Co-authored-by: GaryNg <garyng.zhongbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@santoshbmath @chrisleekr