core(meta-tag-gatherers): meta tag search should be case-insensitive (G…

…oogleChrome#3729) * Metatag search should be case-insensitive * Modify SEO smoke test to test case-insenstive meta tags
christhompson · Nov 17, 2017 · 8d941a8 · 8d941a8
1 parent 7154dc2
commit 8d941a8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lighthouse-cli/test/fixtures/seo/seo-tester.html b/lighthouse-cli/test/fixtures/seo/seo-tester.html
@@ -10,7 +10,7 @@
   <title>SEO audit tester</title>
   <meta charset="utf-8">
   <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0">
-  <meta name="description" content="The premiere destination for testing your SEO audit gathering">
+  <meta name="Description" content="The premiere destination for testing your SEO audit gathering">
 </head>
 <body>
   <h1>SEO</h1>

diff --git a/lighthouse-core/gather/gatherers/seo/meta-description.js b/lighthouse-core/gather/gatherers/seo/meta-description.js
@@ -15,7 +15,7 @@ class MetaDescription extends Gatherer {
   afterPass(options) {
     const driver = options.driver;
 
-    return driver.querySelector('head meta[name="description"]')
+    return driver.querySelector('head meta[name="description" i]')
       .then(node => node && node.getAttribute('content'));
   }
 }

diff --git a/lighthouse-core/gather/gatherers/theme-color.js b/lighthouse-core/gather/gatherers/theme-color.js
@@ -15,7 +15,7 @@ class ThemeColor extends Gatherer {
   afterPass(options) {
     const driver = options.driver;
 
-    return driver.querySelector('head meta[name="theme-color"]')
+    return driver.querySelector('head meta[name="theme-color" i]')
       .then(node => node && node.getAttribute('content'));
   }
 }

diff --git a/lighthouse-core/gather/gatherers/viewport.js b/lighthouse-core/gather/gatherers/viewport.js
@@ -15,7 +15,7 @@ class Viewport extends Gatherer {
   afterPass(options) {
     const driver = options.driver;
 
-    return driver.querySelector('head meta[name="viewport"]')
+    return driver.querySelector('head meta[name="viewport" i]')
       .then(node => node && node.getAttribute('content'));
   }
 }