Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non string/boolean CodeGeneratorSettings are not honored #334

Closed
david-brink-talogy opened this issue Mar 12, 2024 · 3 comments · Fixed by #335
Closed

Non string/boolean CodeGeneratorSettings are not honored #334

david-brink-talogy opened this issue Mar 12, 2024 · 3 comments · Fixed by #335
Assignees
@christianhelle
Labels
bug Something isn't working

Comments

@david-brink-talogy
Copy link
Contributor

Describe the bug
ExcludedTypeNames is not mapped into the NSwag settings. This property is of type string[], but types that are not bool/string are skipped by MapCSharpGeneratorSettings.
@david-brink-talogy david-brink-talogy added the bug Something isn't working label Mar 12, 2024
@david-brink-talogy david-brink-talogy mentioned this issue Mar 12, 2024
Merged
@christianhelle
Copy link
Owner

Thanks for taking the time to report this @david-brink-talogy

@christianhelle
Copy link
Owner

@all-contributors please add @david-brink-talogy for bugs

@allcontributors allcontributors bot mentioned this issue Mar 12, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@christianhelle

I've put up a pull request to add @david-brink-talogy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christianhelle christianhelle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix code generator settings that are not of type string/bool david-brink-talogy/refitter
2 participants
@christianhelle @david-brink-talogy