Fix code generator settings that are not of type string/bool #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianhelle
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 97.34% 97.35%
=======================================
Files 63 63
Lines 2412 2421 +9
=======================================
+ Hits 2348 2357 +9
Misses 40 40
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
christianhelle
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Looks good to me!
Thanks for taking the time to look into the problem and come up with a fix @david-brink-talogy
|
@all-contributors please add @david-brink-talogy for code |
|
I've put up a pull request to add @david-brink-talogy! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334.
@christianhelle , I wasn't sure why only string/bool properties are mapped into NSwag. I added a new check to ensure property types are compatible in hope this may mitigate the problem you were trying to avoid.