Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various name encoding fixes, fix multiline descriptions #12

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

neoGeneva
Copy link
Contributor

Hi there,

I was having some issues with refitter so I've created a fix for them, I hope they're of some use.

Things I've changed are:

  • Multiline descriptions show on new lines without being commented out
  • Query string parameter names aren't being encoded safely, things like dashes and reserved keywords causing problems
  • Client methods aren't being encoded safely, this pull request just deals with full stops, I couldn't see any way to leverage NSwag's encoding
  • Properties with no names aren't generated correctly. This one is weird and might be a bit specific to the doc I'm generating from.
  • Fixed the smoke-test.ps1 cleanup of generated files
  • Added vscode files
  • Added IngramMicro.json sample for smoke tests

@christianhelle christianhelle self-assigned this Mar 22, 2023
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! Thanks for adding a new OpenAPI spec for testing and more thanks for updating the local smoke test script!

@christianhelle christianhelle merged commit 6ae0875 into christianhelle:main Mar 22, 2023
@christianhelle christianhelle added bug Something isn't working enhancement New feature, bug fix, or request labels Mar 22, 2023
@neoGeneva neoGeneva deleted the name-encoding-fixes branch March 23, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants