Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve SonarCloud Code Smells #137

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Resolve SonarCloud Code Smells #137

merged 2 commits into from
Sep 4, 2023

Conversation

christianhelle
Copy link
Owner

No description provided.

…in RefitGenerator

Changed the data type for the 'includeTags' parameter in the 'ProcessTagFilters' method from an array to an IReadOnlyCollection. This reduces memory overhead for large tag lists and improves performance. Also simplified comparison logic to exclude methods without matched tags.
Refactored the process of matching paths with regular expressions in `RefitGenerator`. Instead of iterating over each regex for each path, we now pre-calculate the paths that fail all regex tests. This makes the process more efficient by removing unnecessary iterations over regexes, thus improving overall performance.
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Sep 4, 2023
@christianhelle christianhelle self-assigned this Sep 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #137 (9eee90f) into main (2834bd2) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   98.57%   98.55%   -0.03%     
==========================================
  Files          37       37              
  Lines        1193     1176      -17     
==========================================
- Hits         1176     1159      -17     
  Misses          6        6              
  Partials       11       11              
Flag Coverage Δ
unittests 98.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Refitter.Core/RefitGenerator.cs 100.00% <100.00%> (ø)

@christianhelle christianhelle merged commit 7025d61 into main Sep 4, 2023
746 checks passed
@christianhelle christianhelle deleted the resolve-code-smells branch September 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant