Disable support keys if --no-logging is specified #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the line that configures Analytics from the Main method of the Program class to the Validate method of the GenerateCommand class. This ensures that analytics will only be configured if the 'NoLogging' setting is not active, optimizing performance and improving the user's control over logging.
In the GenerateCommand.cs, the logging statement showing the support key has been modified. The support key statement is now conditioned to only display when logging is enabled in settings. This was done to provide cleaner outputs when logging is disabled.
Adjusted the way the support key is handled when the logging is disabled. Previously, the support key wasn't printed at all if the logging was off. Now, a message specifying that the support key is unavailable when logging is disabled is printed instead. This serves to ensure that users are informed about the unavailability of the support key when logging is off rather than silently omitting it.
christianhelle
changed the title
christianhelle
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip analytics configuration entirely if --no-logging is specified
Moved the line that configures Analytics from the Main method of the Program class to the Validate method of the GenerateCommand class. This ensures that analytics will only be configured if the 'NoLogging' setting is not active, optimizing performance and improving the user's control over logging.
Show a message regarding support keys when logging is disabled
Adjusted the way the support key is handled when the logging is disabled. Previously, the support key wasn't printed at all if the logging was off. A message specifying that the support key is unavailable when logging is disabled is printed instead. This serves to ensure that users are informed about the unavailability of the support key when logging is off rather than silently omitting it.