Generate Refit interfaces as partial #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated interfaces across the codebase were changed from regular to partial. This change allows the clients to extend the functionality of these interfaces without modifying auto-generated code. Tests were also updated to verify this change
Changed the interface declarations in the Refitter.Tests from regular to partial interfaces. This allows for more flexibility in implementation by allowing interfaces to be defined across multiple files, enhancing modularity and readability of the code.
Modified SwaggerPetstore and other related interfaces to being 'partial' in various source files. This allows for these interfaces to be defined in multiple parts for more flexible and manageable codebase extension.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 39 39
Lines 1255 1258 +3
=======================================
+ Hits 1235 1238 +3
Misses 6 6
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All interfaces were changed to partial in both README.md and Refitter/README.md of the SwaggerPetstore project. This allows for easy extension of these interfaces without modifying the generated code. Such a change prepares the code for upcoming features that may require the addition of methods to these interfaces. This is particularly important for maintaining backwards compatibility as the project grows.
Modified the PR template's example of a generated Refit interface. Specifically, the IReferenceparameters interface has been made partial. This change aligns the template with our coding standards that advise using partial interfaces for better modularity and maintenance.
|
Kudos, SonarCloud Quality Gate passed!
|
christianhelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated interfaces across the codebase were changed from regular to partial. This change allows the clients to extend the functionality of these interfaces without modifying auto-generated code. Tests were also updated to verify this change