Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Optional Setting to name the IServiceCollection Extension Method #298

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

robpalm
Copy link
Contributor

@robpalm robpalm commented Jan 18, 2024

Added a new DependencyInjectionSettings Property ExtensionMethodName with DefaultValue ConfigureRefitClients.

It can be set if you want to have control over the IServiceCollection Extension Method Name, or if you have multiple generated Client Api's with Dependency Injection support. Then the Extension Method will conflict.

Fixes #294

Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@christianhelle christianhelle self-assigned this Jan 18, 2024
@christianhelle christianhelle added enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2072def) 97.42% compared to head (3c72051) 97.42%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files          63       63           
  Lines        2366     2367    +1     
=======================================
+ Hits         2305     2306    +1     
  Misses         40       40           
  Partials       21       21           
Flag Coverage Δ
unittests 97.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robpalm thanks for the contribution!

@christianhelle christianhelle merged commit 2e6a261 into christianhelle:main Jan 18, 2024
737 checks passed
@christianhelle
Copy link
Owner

@all-contributors please add @robpalm for code

Copy link
Contributor

@christianhelle

I've put up a pull request to add @robpalm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More than one generated Client Api will result in an Extension Method Conflict for ConfigureRefitClients
2 participants