-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak xml docs #332
Tweak xml docs #332
Conversation
@osc-nseguin Thanks for taking the time to improve this feature! Based on the screenshots, this is really cool! |
@all-contributors please add @osc-nseguin for code |
I've put up a pull request to add @osc-nseguin! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osc-nseguin The tests are unfortunately failing. Do you mind updating XmlDocumentationGeneratorTests
? There are a couple of asserts there that check that the generated code contains the string <throws cref=\"ApiException\">
, and this is no longer valid with your changes
Quality Gate passedIssues Measures |
Sorry, I got a bit impatient and pushed the fixes myself 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 97.33% 97.34% +0.01%
==========================================
Files 63 63
Lines 2402 2412 +10
==========================================
+ Hits 2338 2348 +10
Misses 40 40
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
<list type="table">
Both of these somewhat improve the rendering of the generated comments in Visual Studio and Rider.
Before (Rider):
After (Rider):
Before (Visual Studio):
After (Visual Studio):
The generated code is a little uglier due to the flat nested XML. One could avoid this by refactoring the string builder utility methods.