Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve telemetry for --settings-file usage #419

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

christianhelle
Copy link
Owner

This pull request improves the telemetry for the usage of the --settings-file option. Previously, only the settings-file object was logged, but now the RefitGeneratorSettings object is also logged when the SettingsFilePath is not null. This provides more detailed information for analysis.

@christianhelle christianhelle self-assigned this Jul 18, 2024
@christianhelle christianhelle added enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code labels Jul 18, 2024
Copy link

sonarcloud bot commented Jul 18, 2024

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (808ddc9) to head (14edabb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          64       64           
  Lines        2564     2564           
=======================================
  Hits         2499     2499           
  Misses         40       40           
  Partials       25       25           
Flag Coverage Δ
unittests 97.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit 7ab165a into main Jul 19, 2024
843 checks passed
@christianhelle christianhelle deleted the settings-file-telemetry branch July 19, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant