Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added IgnoreUnrecognizedTypeDiscriminators = true #465

Conversation

ryanheath
Copy link
Contributor

I forgot attribute option IgnoreUnrecognizedTypeDiscriminators = true
otherwise the fallback to base class is still not working ...

fix upon #462

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (646b180) to head (72e42a9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   85.95%   91.77%   +5.82%     
==========================================
  Files          50       50              
  Lines        2769     2638     -131     
==========================================
+ Hits         2380     2421      +41     
+ Misses        357      188     -169     
+ Partials       32       29       -3     
Flag Coverage Δ
unittests 91.77% <100.00%> (+5.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle self-assigned this Sep 11, 2024
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Sep 11, 2024
@christianhelle christianhelle merged commit 01a0d15 into christianhelle:main Sep 11, 2024
5 checks passed
@christianhelle
Copy link
Owner

@ryanheath I'll publish a new pre-release that includes this fix

Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants