Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query] Required query params must be initialized from constructor #506

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

JeremyBP
Copy link
Contributor

@JeremyBP JeremyBP commented Oct 7, 2024

As (self-)suggested in my comment, here is the PR extending #417 that includes required query params into dynamic query parameter's constructor, when UseDynamicQuerystringParameters option is enabled.
Test updated.
Doc not updated but I don't think we have something to say into it about that, as asking for something mandatory seems obvious to me :)

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (c00b6dd) to head (fa13e31).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   98.89%   98.90%           
=======================================
  Files          51       51           
  Lines        2452     2457    +5     
=======================================
+ Hits         2425     2430    +5     
  Misses          4        4           
  Partials       23       23           
Flag Coverage Δ
unittests 98.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle self-assigned this Oct 7, 2024
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Oct 7, 2024
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks for the contribution @JeremyBP

@christianhelle christianhelle merged commit 6e1a803 into christianhelle:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants