Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced HTTP status code 200 handling for API responses #74

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

NoGRo
Copy link
Contributor

@NoGRo NoGRo commented Jun 15, 2023

Enhanced HTTP status code handling for API responses

Previously, our API handling logic only checked for a '200' HTTP status code to retrieve the response schema. However, there are several other success status codes, like '201', '203', and '206', which also indicate that the request was successful and can include a response schema.

https://restfulapi.net/http-status-codes/#2xx

Enhanced HTTP status code handling for API responses

Previously, our API handling logic only checked for a '200' HTTP status code to retrieve the response schema. However, there are several other success status codes, like '201', '203', and '206', which also indicate that the request was successful and can include a response schema.
Copy link
Owner

@christianhelle christianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks for the contribution @NoGRo

@NoGRo
Copy link
Contributor Author

NoGRo commented Jun 15, 2023

miss some using

@christianhelle
Copy link
Owner

@all-contributors please add @NoGRo for code

@allcontributors
Copy link
Contributor

@christianhelle

I've put up a pull request to add @NoGRo! 🎉

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Jun 15, 2023
@christianhelle christianhelle merged commit 577362c into christianhelle:main Jun 15, 2023
@christianhelle
Copy link
Owner

This is now release to nuget.org as v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants