Add support for storing icon SVGs as strings #37 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line break mismatch on Windows vs. Mac/Linux machines
blueputty01
force-pushed
the
svg-store
branch
2 times, most recently
from
8eb5574
to
fad91f1
Compare
Watch doesn't work on windows (github.com/sanity-io/pkg-utils/pull/85)
christopherafbjur
requested changes
Jun 14, 2023
christopherafbjur
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks for your contribution @blueputty01 very good job on the discussions and implementation of this feature 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores html of SVG icons rendered in the search interface
Resolves #37
Proposes lighter solution in parallel to #39.
Specifically, this PR proposes: